[Selenium] Add DevWorkspaceHappyPath e2e typescript test #19152
Conversation
SkorikSergey
added
status/in-progress
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
| suite('Workspace creation via factory url', async () => { | ||
|
|
||
| let factoryUrl : string = `${TestConstants.TS_SELENIUM_DEVWORKSPACE_URL}`; | ||
| const workspaceSampleName: string = 'web-nodejs-sample'; |
There was a problem hiding this comment.
Workspace name web-nodejs-sample could be misleading depending on which devworkspace devfile URL is set.
What if we name test workspace as devworkspace-sample, not linking to concrete supported language?
There was a problem hiding this comment.
For now this test will check workspace created from flattened_theia-next.yaml yaml. And it uses web-nodejs-sample.
There was a problem hiding this comment.
IF there is only one type of supported workspaces, I might make sense to express it in the test code, e.g.:
// This test checks only workspace created from "web-nodejs-sample" https://github.com/devfile/devworkspace-operator/blob/main/samples/flattened_theia-next.yaml.
| /** | ||
| * URL of the workspace created by devworkspace-controller | ||
| */ | ||
| TS_SELENIUM_DEVWORKSPACE_URL: process.env.TS_SELENIUM_DEVWORKSPACE_URL |
There was a problem hiding this comment.
Is it actually existed workspace URL or URL to it's devfile ?
If it's URL to devfile which is used to create devworkspace, TS_SELENIUM_DEVWORKSPACE_DEVFILE_URL name is more relevant to value.
There was a problem hiding this comment.
It is url of existed workspace.
There was a problem hiding this comment.
I see. We can keep it as proof of conception, but in future there should be factory URL with link to raw devfile, as far as I know.
Co-authored-by: Radim Hopp <rhopp@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
SkorikSergey
requested review from
musienko-maxim,
nickboldt and
Ohrimenko1988
as code owners
SkorikSergey
added
status/code-review
…o addDevWorkspaceHappyPath
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
che-bot
removed
the
status/code-review
What does this PR do?
Add DevWorkspaceHappyPath typescript e2e test that will check workspaces created by devworkspace-controller.
What issues does this PR fix or reference?
#18888